Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add http-status-codes dep #212

Merged
merged 4 commits into from
Oct 25, 2019
Merged

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Oct 19, 2019

Type: feat
Scope: commons

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:

Add usage of http-status-codes, it i more reliable, in the future I will replace it completely and spread all values.

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files          26       26           
  Lines        1401     1401           
  Branches      204      204           
=======================================
  Hits          917      917           
  Misses        481      481           
  Partials        3        3
Flag Coverage Δ
#core 88.18% <ø> (ø) ⬆️
#plugins 58.43% <ø> (ø) ⬆️
Impacted Files Coverage Δ
core/commons-api/src/index.ts 86.95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd78a8d...9264e5f. Read the comment docs.

Copy link
Member

@sergiohgz sergiohgz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@juanpicado juanpicado merged commit 00b66af into master Oct 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the improve-commons-http-status branch October 25, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants