Fix incorrect result of #5186 due to width mismatch #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yTakatsukasa
changed the title
yTakatsukasa
commented
Jun 22, 2024
Comment on lines
+856
to
+857
| const int maskWidth | ||
| = std::max(resultp->width(), resultWidth == 1 ? VL_IDATASIZE : resultWidth); |
There was a problem hiding this comment.
If simplify to maskWidth = resultp->width(); , t_const_bitoptree_bug3096 fails.
Until all width becomes correct, this is safer.
|
@wsnyder could you please take a look at this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.