Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 errors should convert to strings via str() rather than e.message #34

Merged
merged 1 commit into from
Aug 16, 2021
Merged

python3 errors should convert to strings via str() rather than e.message #34

merged 1 commit into from
Aug 16, 2021

Conversation

Ghnuberath
Copy link
Contributor

@Ghnuberath Ghnuberath commented Jul 28, 2021 •
edited
Loading

Closes #33

Resolves an undesired AttributeError which obscures the underlying ConnectionError.

ofpiyush
ofpiyush approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@ofpiyush ofpiyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Ghnuberath for this!

@avinassh avinassh merged commit 2c78080 into verloop:main Aug 16, 2021
@avinassh
Copy link
Contributor

Thank you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofpiyush ofpiyush ofpiyush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrapping ConnectionErrors in python3 results in an AttributeError
3 participants
@Ghnuberath @avinassh @ofpiyush