Skip to content

Commit

Permalink
fix: published dependencies of bigtable-beam-import (googleapis#3600)
Browse files Browse the repository at this point in the history
Due to a bug in maven shade plugin 3.3.0,  compile dependencies got stripped from bigtable-beam-import. This bug only affects artifacts where shadedArtifactAttached=true.

Reference: https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-419
  • Loading branch information
igorbernstein2 authored and vermas2012 committed May 3, 2022
1 parent 45a8e1e commit 4484753
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ limitations under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.3.0</version>
<!-- MSHADE-419: 3.3.0 Shade plugin causes pom to be created without compile dependencies -->
<version>3.2.4</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
7 changes: 7 additions & 0 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@
// pin to bigtable version
"packagePatterns": ["^grpc-conscrypt.version"],
"enabled": false
},
{
"packagePatterns": [
"^org.apache.maven.plugins:maven-shade-plugin"
],
// Exclude version 3.3.0 due to https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-419
"allowedVersions": "(,3.3.0),(3.3.0,)"
}
],
"semanticCommits": true,
Expand Down

0 comments on commit 4484753

Please sign in to comment.