win support #329

haiyangwu · 2019-08-29T07:24:26Z

Installation for Win

ensure your host satisfies the following requirements:

Visual Studio 2015/2017
Add the path of MSBuild.exe to System Environment Variable (eg. C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin)
Add GYP_MSVS_VERSION to System Environment Variable (eg. 2017 for visual studio 2017 )

key changes:

using gulp shell and MSBuild to build project
using two pipes to replace the duplex pipe to avoid deadlock, the related bug in NodeJS: Creation of full duplex pipe via spawn causes deadlock on Windows nodejs/node#29238

supported scripts:

lint
format:worker
test:node
coverage:node
postinstall

not supported scripts:

test:worker (haven't found an alternative tool to replace lcov in windows, but running in visual studio is ok )

not sure

changes about channels and pipes

saghul · 2019-08-29T08:41:06Z

* **using two pipes to replace the duplex pipe to avoid deadlock**, the related bug in NodeJS: [nodejs/node#29238](https://github.com/nodejs/node/issues/29238)

That is solved by passing the UV_OVERLAPPED_PIPE flag when creating the pipe. It's a noop on Unix. See: libuv/libuv@62a0f76

jmillan · 2019-08-29T10:42:32Z

looks great @haiyangwu,

using two pipes to replace the duplex pipe to avoid deadlock, the related bug in NodeJS:
nodejs/node#29238

That is solved by passing the UV_OVERLAPPED_PIPE flag when creating the pipe. It's a noop on >Unix. See: libuv/libuv@62a0f76

Could you please try the UV_OVERLAPPED_PIPE flag and adapt the PR accordingly?

.eslintrc.js

.gitignore

gulpfile.js

lib/Channel.js

worker/src/Settings.cpp

worker/src/Worker.cpp

worker/src/handles/TcpConnection.cpp

worker/test/include/helpers.hpp

ibc · 2019-08-29T10:58:56Z

It's not enough. The bug is also in Node usage of libuv.

worker/include/RTC/RTCP/FeedbackPsFir.hpp

worker/src/RTC/DtlsTransport.cpp

worker/include/opt/getopt.h

gulpfile.js

package.json

test/test-Worker.js

worker/deps/getopt/getopt.gyp

worker/include/Channel/Request.hpp

worker/src/Channel/Request.cpp

ibc · 2019-10-01T12:29:50Z

Hi, @haiyangwu. The "devel" branch with work-in-progress transport-cc support is now in GitHub:

https://github.com/versatica/mediasoup/tree/devel

May you please try to merge your branch with Win support into the new "devel" branch? Some notes:

If you need to modify any file under worker/deps/libwebrtc, please let's know first as those are files from Google's libwebrtc.
I hope you don't need to modify anything in worker/deps/libwebrtc/deps/abseil-cpp, but if so, please let's also know. May be modifications into its .gyp` file are required.

haiyangwu · 2019-10-03T18:21:39Z

@ibc Merged and all tests passed. Just like your comment, require some modifications in worker/deps/libwebrtc/deps/abseil-cpp's gyp file which is also described abseil-cpp/CMake/README.md

haiyangwu · 2019-10-03T18:36:04Z

@ibc 🤔Checks failed. Is the config wrong? May you please check it.

ibc · 2019-10-04T17:31:12Z

The failing travis task is this:

../deps/libwebrtc/deps/abseil-cpp/abseil-cpp/absl/base/policy_checks.h:77:2: error: #error "C++ versions less than C++11 are not supported."
 #error "C++ versions less than C++11 are not supported."
  ^
In file included from ../deps/libwebrtc/deps/abseil-cpp/abseil-cpp/absl/strings/string_view.h:51:0,
                 from ../deps/libwebrtc/deps/abseil-cpp/abseil-cpp/absl/strings/match.h:38,
                 from ../deps/libwebrtc/deps/abseil-cpp/abseil-cpp/absl/strings/match.cc:15:
../deps/libwebrtc/deps/abseil-cpp/abseil-cpp/absl/base/internal/throw_delegate.h:39:1: error: expected unqualified-id before ‘[’ token
 [[noreturn]] void ThrowStdLogicError(const std::string& what_arg);
 ^

It's like we need to force C++11 in the gyp of abseil-cpp, am I right?

ibc · 2019-10-04T18:17:49Z

NOTE: We did never run the "deve" branch in Travis, so...

ibc · 2019-10-04T18:24:32Z

worker/deps/abseil-cpp/abseil-cpp.gyp

+        'defines': [
+          'NOMINMAX', # Don't define min and max macros (windows.h)
+          # Don't bloat namespace with incompatible winsock versions.
+          'WIN32_LEAN_AND_MEAN',
+          # Don't warn about usage of insecure C functions.
+          '_CRT_SECURE_NO_WARNINGS',
+          '_SCL_SECURE_NO_WARNINGS',
+          # Introduced in VS 2017 15.8, allow overaligned types in aligned_storage
+          '_ENABLE_EXTENDED_ALIGNED_STORAGE'
+        ]


NOTE: worker/deps/abseil-cpp has been removed in "devel" branch. It's now just in worker/deps/libwebrtc/deps/abseil-cpp.

Ok... New commits in devel branch merged.

ibc · 2019-10-04T18:30:24Z

It's like we need to force C++11 in the gyp of abseil-cpp, am I right?

I've added it in devel branch: 780d1c1

ibc · 2019-10-04T18:39:55Z

BTW, regarding run-script-os dep now I'm 100% confused. I understood in the past that we should use this one, however the same author is also updating this one.

I've asked the author (@kawatzaki) here :)

kawatzaki · 2019-10-04T18:56:36Z

Hi fellas, don't worry about @dr.amaton/run-script-os, we just updated to 1.1.3, which shouldn't break anything at all, I was just clarifying which repo should be updated and which should be left alone....

Keep this project going!

ibc · 2019-10-04T20:14:32Z

Thanks a lot for the clarification, @kawatzaki :)

ibc · 2019-10-05T12:52:04Z

@haiyangwu can you please make this PR against the "devel" branch instead? We don't want to merge "devel" into "v3" yet (it's not ready).

haiyangwu · 2019-10-06T01:58:06Z

@haiyangwu can you please make this PR against the "devel" branch instead? We don't want to merge "devel" into "v3" yet (it's not ready).

This PR's base branch already switched to "devel" branch. BTW, doc works about "requirements" as below still need to add, please let me know when the proper time and tell me where it should be put.

ensure your host satisfies the following requirements:

Visual Studio 2015/2017

Add the path of MSBuild.exe to System Enviroment (eg. C:\Program Files (x86)\MSBuild\14.0\Bin)

Add GYP_MSVS_VERSION to System Enviroment (eg. 2017 for visual studio 2017 )

ibc

Just two minor changes, please (two dots) :)

worker/deps/libwebrtc/deps/abseil-cpp/abseil-cpp.gyp

worker/include/common.hpp

ibc · 2019-10-06T09:28:14Z

@haiyangwu can you please make this PR against the "devel" branch instead? We don't want to merge "devel" into "v3" yet (it's not ready).

This PR's base branch already switched to "devel" branch.

Great, please just add two missing dots (as requested) and I'll merge it.

BTW, doc works about "requirements" as below still need to add, please let me know when the proper time and tell me where it should be put.

ensure your host satisfies the following requirements:

Visual Studio 2015/2017

Add the path of MSBuild.exe to System Enviroment (eg. C:\Program Files (x86)\MSBuild\14.0\Bin)

Add GYP_MSVS_VERSION to System Enviroment (eg. 2017 for visual studio 2017 )

Don't worry, I'll add those requirements in the mediasoup website :)

ibc · 2019-10-06T16:08:21Z

Hi @haiyangwu, merged! so many thanks! This will be eventually merged into v3 once we end dealing with transport-cc. BTW let me two questions:

Is this ok and accurate?: https://mediasoup.org/documentation/v3/mediasoup/installation/#windows
I've added you to Acknowledgements. Is Haiyang Wu your name? and do you have a preferred personal site?

haiyangwu · 2019-10-07T06:30:18Z

@ibc My pleasure.

Is this ok and accurate?: https://mediasoup.org/documentation/v3/mediasoup/installation/#windows

For accurate, please change a little bit.

Append the path of MSBuild.exe folder to PATH in Windows environment variable (e.g. C:\Program Files (x86)\MSBuild\14.0\Bin).
Create a new Windows environment variable GYP_MSVS_VERSION to demostrate Vistual Studio's version (e.g. 2017 for Visual Studio 2017).

I've added you to Acknowledgements. Is Haiyang Wu your name? and do you have a preferred personal site?

Thanks again and yes my name is Haiyang Wu. Linking to Github is ok.

ibc · 2019-10-07T08:48:06Z

Thanks, done.

ibc · 2019-10-29T15:57:59Z

@haiyangwu may you please check whether the new "scripts" in package.json in the typescript branch run fine in Windows?

ibc · 2019-10-29T17:41:51Z

Also @haiyangwu, there is an important issue due the usage of "@dr.amaton/run-script-os":

kawatzaki/dr.amaton-run-script-os#1

I hope @kawatzaki can take a look to it since this's a show stopper for me right now :)

kawatzaki · 2019-10-29T18:08:39Z

I'll be checking it out, I'm currently at lunch!

But I'll get it fixed today

haiyangwu · 2019-10-30T01:03:31Z

Also @haiyangwu, there is an important issue due the usage of "@dr.amaton/run-script-os":

kawatzaki/dr.amaton-run-script-os#1

I hope @kawatzaki can take a look to it since this's a show stopper for me right now :)

@ibc I saw the issue closed (add extra --no-arguments. It works in OSX now? I just want to confirm and I'll check it in Windows.

ibc · 2019-10-30T09:06:47Z

Yes, with --no-arguments it works (pushed to "devel" branch).

haiyangwu added 6 commits August 26, 2019 16:42

build for win

be16bb5

code style

e9ee7c3

code style

27c1307

scripts

f2b060e

replace duplex pipe with two pipe

8de983a

code style

3e57e56

haiyangwu marked this pull request as ready for review August 29, 2019 07:28

ibc requested changes Aug 29, 2019

View reviewed changes

saghul reviewed Aug 29, 2019

View reviewed changes

worker/include/RTC/RTCP/FeedbackPsFir.hpp Outdated Show resolved Hide resolved

ibc requested changes Aug 29, 2019

View reviewed changes

worker/src/RTC/DtlsTransport.cpp Show resolved Hide resolved

ibc requested changes Aug 29, 2019

View reviewed changes

worker/include/opt/getopt.h Outdated Show resolved Hide resolved

haiyangwu added 10 commits August 30, 2019 10:29

add explicit key word

12b6a3c

move getopt to deps

283351a

Merge remote-tracking branch 'versatica/v3' into v3. Fix typo

9cd71b3

single quotes

a15863c

pyc explicit path

b86a32f

delete unused dep

9a66008

log text & code style

c20fb5b

rename SocketRole to role

850761f

log text & code style

6a1a927

replace _MSC_VER with _WIN32 for better compatibility

af693c4

versatica deleted a comment Aug 30, 2019

add public keyword to separate method and var

d3f3a4c

versatica deleted a comment Aug 30, 2019

Generate sln under worker directory for unifying test:woker logic

cbc1b1d

versatica deleted a comment Aug 30, 2019

ibc requested changes Aug 30, 2019

View reviewed changes

haiyangwu added 3 commits October 4, 2019 00:01

Merge remote-tracking branch 'versatica/devel' into v3

3dddc43

add defines for abseil

7ac3a99

include

461e7a5

ibc reviewed Oct 4, 2019

View reviewed changes

Merge remote-tracking branch 'versatica/devel' into v3

96a62bd

haiyangwu changed the base branch from v3 to devel October 6, 2019 01:43

ibc requested changes Oct 6, 2019

View reviewed changes

worker/deps/libwebrtc/deps/abseil-cpp/abseil-cpp.gyp Outdated Show resolved Hide resolved

worker/include/common.hpp Outdated Show resolved Hide resolved

dot at the end of the comment

62aeb29

ibc approved these changes Oct 6, 2019

View reviewed changes

ibc merged commit a42e5c4 into versatica:devel Oct 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

win support #329

win support #329

haiyangwu commented Aug 29, 2019 •

edited

Loading

saghul commented Aug 29, 2019

jmillan commented Aug 29, 2019 •

edited

Loading

ibc commented Aug 29, 2019

ibc commented Oct 1, 2019

haiyangwu commented Oct 3, 2019

haiyangwu commented Oct 3, 2019

ibc commented Oct 4, 2019

ibc commented Oct 4, 2019

ibc Oct 4, 2019

haiyangwu Oct 5, 2019

ibc commented Oct 4, 2019

ibc commented Oct 4, 2019

kawatzaki commented Oct 4, 2019

ibc commented Oct 4, 2019

ibc commented Oct 5, 2019

haiyangwu commented Oct 6, 2019

ibc left a comment

ibc commented Oct 6, 2019

ibc commented Oct 6, 2019

haiyangwu commented Oct 7, 2019

ibc commented Oct 7, 2019

ibc commented Oct 29, 2019

ibc commented Oct 29, 2019

kawatzaki commented Oct 29, 2019

haiyangwu commented Oct 30, 2019

ibc commented Oct 30, 2019

win support #329

win support #329

Conversation

haiyangwu commented Aug 29, 2019 • edited Loading

Installation for Win

key changes:

supported scripts:

not supported scripts:

not sure

saghul commented Aug 29, 2019

jmillan commented Aug 29, 2019 • edited Loading

ibc commented Aug 29, 2019

ibc commented Oct 1, 2019

haiyangwu commented Oct 3, 2019

haiyangwu commented Oct 3, 2019

ibc commented Oct 4, 2019

ibc commented Oct 4, 2019

ibc Oct 4, 2019

Choose a reason for hiding this comment

haiyangwu Oct 5, 2019

Choose a reason for hiding this comment

ibc commented Oct 4, 2019

ibc commented Oct 4, 2019

kawatzaki commented Oct 4, 2019

ibc commented Oct 4, 2019

ibc commented Oct 5, 2019

haiyangwu commented Oct 6, 2019

ibc left a comment

Choose a reason for hiding this comment

ibc commented Oct 6, 2019

ibc commented Oct 6, 2019

haiyangwu commented Oct 7, 2019

ibc commented Oct 7, 2019

ibc commented Oct 29, 2019

ibc commented Oct 29, 2019

kawatzaki commented Oct 29, 2019

haiyangwu commented Oct 30, 2019

ibc commented Oct 30, 2019

haiyangwu commented Aug 29, 2019 •

edited

Loading

jmillan commented Aug 29, 2019 •

edited

Loading