Improvements #71
Improvements #71
Conversation
|
|
||
| The fallback receives a: | ||
|
|
||
| * {@link io.vertx.circuitbreaker.OpenCircuitException} when the circuit breaker is opened |
There was a problem hiding this comment.
Why is this section about reported exception deleted ?
There was a problem hiding this comment.
It isn't deleted, it's moved up a little: 41fd1cf#diff-97965d9bb2e3f738e48945f14914e26a4f3c5ae77cfeb5f339009e191124f2beR88
|
Added one more commit that mentions Resilience4j at the end of the documentation (where Hystrix usage used to be documented). The documentation is very brief, it mostly just points to the recently published how-to: https://how-to.vertx.io/resilience4j-howto/ |
Another option would be a Reactiverse project for Resilience4j integration |
|
That would make sense too, good point! |
|
can you rebase this PR please @Ladicek ? |
The documentation used to describe how to use Hystrix with Vert.x. Since Hystrix has been obsolete for a long time and the documentation was removed in a recent commit, this commit adds a modern replacement: Resilience4j. The documentation mainly links to the Resilience4j Vert.x how-to that was published recently.
Ladicek
force-pushed
the
improvements
branch
from
adeb7b5
to
50ffaf4
Compare
|
Rebased. |
|
Thanks @Ladicek |
Motivation:
The context is vert-x3/issues#633, and this commit is a first step towards that goal. It does:
I have also started working on a Resilience4j howto, which shall be linked from the documentation here. In fact, I already have Vert.x wrappers for all Resilience4j fault tolerance patterns (bulkhead, circuit breaker, rate limiter, retry, time limiter -- I didn't include cache for obvious reasons), so we could possibly make into a full-fledged extension (and deprecate the Vert.x circuit breaker maybe?). That's for later, for sure.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines