Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmdbslab.dropdb, initdb fixes #1174

Merged
merged 6 commits into from
Mar 20, 2019
Merged

lmdbslab.dropdb, initdb fixes #1174

merged 6 commits into from
Mar 20, 2019

Conversation

jnwatson
Copy link
Contributor

*Fix failure in dropdb. Made similar change to initdb to match
*Fix logger formatting failure in lmdblayer
*Separate maxsize test to fix occasional test failure
*Optimize mapfull_runsyncloop test
*Reduce copydb progress report rate

dropdb could raise lmdb.MapFullError. This requires an API change from
passing the DB name instead of the DB object.

Fix failure in dropdb.  Made similar change to initdb to match
Fix logger formatting failure in lmdblayer
Separate maxsize test to fix occasional test failure
Optimize mapfull_runsyncloop test

dropdb could raise lmdb.MapFullError.  This requires an API change from
passing the DB name instead of the DB object.
@vertexproject vertexproject deleted a comment from codecov bot Mar 20, 2019
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #1174 into master will increase coverage by <.01%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   93.36%   93.37%   +<.01%     
==========================================
  Files         122      122              
  Lines       16238    16250      +12     
==========================================
+ Hits        15161    15173      +12     
  Misses       1077     1077
Impacted Files Coverage Δ
synapse/lib/lmdbslab.py 97.02% <100%> (-0.16%) ⬇️
synapse/lib/lmdblayer.py 88.1% <50%> (ø) ⬆️
synapse/lib/storm.py 93.16% <0%> (-0.21%) ⬇️
synapse/cortex.py 90.43% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84e2e6...a14d0b4. Read the comment docs.

@jnwatson jnwatson merged commit d6a7b0d into master Mar 20, 2019
@jnwatson jnwatson deleted the drop-mapfull branch March 20, 2019 18:50
@vEpiphyte vEpiphyte added this to the v0.1.1 milestone Mar 25, 2019
@vEpiphyte vEpiphyte added the bug label Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants