Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPAPI documentation and fini issue #1211

Merged
merged 4 commits into from
Apr 26, 2019
Merged

HTTPAPI documentation and fini issue #1211

merged 4 commits into from
Apr 26, 2019

Conversation

vEpiphyte
Copy link
Contributor

  • Replace httpapi rst with ipynb.
  • Add test coverage for addHttpPort on the cell.
  • Ensure that cell http servers have .stop() called on them during fini.

@vEpiphyte vEpiphyte added this to the v0.1.4 milestone Apr 26, 2019
@vEpiphyte vEpiphyte self-assigned this Apr 26, 2019
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1211 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
+ Coverage   93.53%   93.55%   +0.02%     
==========================================
  Files         124      124              
  Lines       16611    16613       +2     
==========================================
+ Hits        15537    15543       +6     
+ Misses       1074     1070       -4
Impacted Files Coverage Δ
synapse/lib/cell.py 93.66% <100%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b66da...b892c48. Read the comment docs.

@vEpiphyte vEpiphyte merged commit bc8bd7a into master Apr 26, 2019
@vEpiphyte vEpiphyte deleted the docs_httpapi_ipynb branch April 26, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant