Fix filtering and lifting by a tag with a variable #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
==========================================
+ Coverage 93.94% 93.95% +<.01%
==========================================
Files 126 126
Lines 16128 16143 +15
==========================================
+ Hits 15152 15167 +15
Misses 976 976
Continue to review full report at Codecov.
|
invisig0th
requested changes
May 8, 2019
| name = await kid.compute(path) | ||
|
|
||
| if name == '*': | ||
| return bool(node.tags) |
There was a problem hiding this comment.
<3 avoidance of conditional logic
vEpiphyte
reviewed
May 9, 2019
vEpiphyte
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.