fix for mirror window consumer #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invisig0th
commented
Jun 6, 2019
| @@ -842,7 +841,7 @@ class Cortex(s_cell.Cell): | |||
| await layr.setOffset(layr.iden, items[-1][0]) | |||
|
|
|||
| except asyncio.CancelledError: # pragma: no cover | |||
| raise | |||
| return | |||
There was a problem hiding this comment.
Since this is the main function for the coroutine, catching and handling CancelledError is ok here
There was a problem hiding this comment.
Doesn't matter either way since schedCoro will swallow the cancellederror
Codecov Report
@@ Coverage Diff @@
## master #1264 +/- ##
==========================================
+ Coverage 94.24% 94.27% +0.03%
==========================================
Files 126 126
Lines 16620 16620
==========================================
+ Hits 15664 15669 +5
+ Misses 956 951 -5
Continue to review full report at Codecov.
|
jnwatson
previously approved these changes
Jun 6, 2019
| @@ -842,7 +841,7 @@ class Cortex(s_cell.Cell): | |||
| await layr.setOffset(layr.iden, items[-1][0]) | |||
|
|
|||
| except asyncio.CancelledError: # pragma: no cover | |||
| raise | |||
| return | |||
There was a problem hiding this comment.
Doesn't matter either way since schedCoro will swallow the cancellederror
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.