Runtsafe order bug #1265
Merged
Runtsafe order bug #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens if len(line) > 60 and error was in the first 30 chars.
vEpiphyte
reviewed
Jun 6, 2019
invisig0th
requested changes
Jun 6, 2019
synapse/tests/test_cortex.py
Outdated
| @@ -2768,6 +2768,12 @@ class Bawk: | |||
| nodes = await core.nodes(q) | |||
| self.len(1, nodes) | |||
|
|
|||
| async def test_storm_order(self): | |||
| q = '''[test:str=foo :hehe=bar] $tvar=$lib.text('') $tvar.add(1) $tvar.add(:hehe) $lib.print($tvar.str()) ''' | |||
There was a problem hiding this comment.
$lib.text() doesn't need the '' arg
invisig0th
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[test:str=foo :hehe=bar] $tvar=$lib.text('') $tvar.add(1) $tvar.add(:hehe) $lib.print($tvar.str())would evaluate adding :hehe and 1 in the wrong order.
Also fix a bug in error printing in cmdr on a long line with the syntax error near the beginning of the line.