Capture root logger messages in the Cell when using our custom log Handler (SYN-8012) #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a initFromArgv, plumb it up into storm (SYN-8012)
vEpiphyte
changed the title
…it in the root logger.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3922 +/- ##
==========================================
- Coverage 96.35% 96.24% -0.12%
==========================================
Files 245 245
Lines 54707 54755 +48
==========================================
- Hits 52715 52700 -15
- Misses 1992 2055 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vEpiphyte
changed the title
vEpiphyte
commented
Oct 1, 2024
| if self._syn_log_queue is None: | ||
| raise s_exc.SynErr(mesg='no queue available') | ||
| for mesg in list(self._syn_log_queue): | ||
| yield mesg |
There was a problem hiding this comment.
including leading timestamp
There was a problem hiding this comment.
Window this output so we can do live output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.