Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change app.kubernetes.io/name label #384

Closed
nyikesda opened this issue Apr 20, 2023 · 0 comments · Fixed by #394
Closed

Ability to change app.kubernetes.io/name label #384

nyikesda opened this issue Apr 20, 2023 · 0 comments · Fixed by #394

Comments

@nyikesda
Copy link
Contributor

There is a supported way to change labels with spec.labels in all objects what is created by operator, but it is not supported to change the app.kubernetes.io/name label from 'vertica' to anything else, because if it is changed, then operator won't see the created objects in certain operations, for example during a vertica upgrade operator won't change vertica image version in the statefulset, but changes all other thing in the statefulset :)

If it is possible, then it would be great to get the ability to change the app.kubernetes.io/name label as well, because we have other Kubernetes manifests as well in the deployment, and all other has our self app.kubernetes.io/name label, except Vertica pods :(

roypaulin added a commit that referenced this issue May 11, 2023
We can now set the following label in the CR:
```
spec:
  labels:
    app.kubernetes.io/name: "org-name"
```
All k8s created object will have it. If it is not set in the CR, it will
assume the default value which is `vertica`.

A webhook has also been added to prevent other internally used labels to
be overridden.

Closes #384

---------

Co-authored-by: Matt Spilchen <matt.spilchen@vertica.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant