Allow app.kubernetes.io/name to be set in the VerticaDB CR #394
Conversation
api/v1beta1/labels.go
Outdated
There was a problem hiding this comment.
I understand why you have to move the labels out of the builder package. But, could we just put it in its own package rather than here? Maybe create a package named meta and put the constants for labels and annotations in it.
There was a problem hiding this comment.
Yes I think putting all labels/annotations code in its own package makes more sense.
api/v1beta1/verticadb_webhook.go
Outdated
| invalidLabels := make([]string, len(ProtectedLabels)) | ||
| copy(invalidLabels, ProtectedLabels) |
There was a problem hiding this comment.
Why do need to make a copy of ProtectedLabels? Could we just iterate over that one?
There was a problem hiding this comment.
Yes we don't need.
pkg/builder/labels_annotations.go
Outdated
| OperatorVersion110 = "1.1.0" | ||
| OperatorVersion120 = "1.2.0" | ||
| OperatorVersion130 = "1.3.0" | ||
| NameLabel = "app.kubernetes.io/name" |
There was a problem hiding this comment.
Any reason this wasn't move to the package with all of the label const?
There was a problem hiding this comment.
Because it is the only place it is used. I am going to create a new package for labels/annotations and move all const labels there.
We can now set the following label in the CR:
All k8s created object will have it. If it is not set in the CR, it will assume the default value which is
vertica.A webhook has also been added to prevent other internally used labels to be overridden.
Closes #384