Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow webhook CA bundle to be taken from secret #273

Merged
merged 5 commits into from
Oct 22, 2022

Commits on Oct 20, 2022

  1. Allow webhook CA bundle to be taken from secret

    Previously, if you are providing your own certs for the webhook, the CA
    bundle had to be specified as a helm chart parameter. This made it
    harder to deploy the operator if the cert was generated through a helm
    chart too because you won't know what the cert is when you deploy your
    app.
    
    This change is to allow the CA cert to be read from the
    webhook.tlsSecret. If that secret has the key ca.crt, then it will be
    patched in the webhook config by the operator.
    
    The secret that contains the tlsSecret has to provided to the operator
    now. An empty string implies the operator will generate the certificate
    internally.
    
    Support for deploying without the webhook had to fixed as it was broken
    in the prior change that relaxed the cert-manager dependency.
    
    The default name of the tls secret when using cert-manager was updated
    to reflect the name chosen when installing with olm.
    
    Some e2e cleanup was added. The custom-cert-webhook had some logging
    testing that was moved to its own test. Then I created a copy of
    custom-cert-webhook for when the CA bundle is in the secret.
    Matt Spilchen committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    40cd0aa View commit details
    Browse the repository at this point in the history
  2. Address review comments

    Matt Spilchen committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d30bd2d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Update e2e failures

    Matt Spilchen committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    1056b77 View commit details
    Browse the repository at this point in the history
  2. Add changie

    Matt Spilchen committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f19efc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Add back wait-for-webhook

    Matt Spilchen committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    682b97c View commit details
    Browse the repository at this point in the history