feat: open/close widget btn - swap icon when widget is opened #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagovalverde
force-pushed
the
feat-add-close-icon
branch
from
5747031 to
fe9c7c8
Compare
Deploying astral-accessibility with
|
| Latest commit: |
bc3919a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23cac14b.astral-accessibility.pages.dev |
| Branch Preview URL: | https://feat-add-close-icon.astral-accessibility.pages.dev |
Deploying astral-accessibility with
|
| Latest commit: |
5747031
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd67a2d5.astral-accessibility.pages.dev |
| Branch Preview URL: | https://feat-add-close-icon.astral-accessibility.pages.dev |
tiagovalverde
changed the title
tiagovalverde
force-pushed
the
feat-add-close-icon
branch
from
fe9c7c8 to
bc3919a
Compare
cherylchen2
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement
Widget users provided the feedback that it is not clear how to close the accessibility widget. To make it more clear to the user, we swap the icon of the button when the widget is opened. I
Current Version
New Version