fix: [SD-9349] screen reader for edge android #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying astral-accessibility with
|
| Latest commit: |
898193b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d62a1f9.astral-accessibility.pages.dev |
| Branch Preview URL: | https://edge-android-reader-fix.astral-accessibility.pages.dev |
yuskhan
force-pushed
the
edge-android-reader-fix
branch
from
6ca8858 to
988a0b1
Compare
AhmedHalat
changed the title
AhmedHalat
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Screen reader broken on Edge Android.
https://vertoinc.atlassian.net/browse/SD-9349
Cause
No voices were available when calling
speechSynthesis.getVoices(), it's a bug within Edge Android itself.https://answers.microsoft.com/en-us/microsoftedge/forum/all/text-to-speech-speech-synthesis-broken-on-mobile/f160ee1a-dd68-436e-b44b-64d1203411e7
Fix
Don't set the voice, it still works when it's null.