Use a list comprehension instead of this weird nested filter.

very-scary-scenario · Oct 18, 2023 · bdc49b3 · bdc49b3
1 parent 9e91081
commit bdc49b3
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/nkdsu/apps/vote/models.py b/nkdsu/apps/vote/models.py
@@ -253,12 +253,11 @@ def shortlisted(self) -> list[Track]:
 
     @memoize
     def discarded(self) -> list[Track]:
-        return list(
-            filter(
-                lambda t: t not in self.playlist(),
-                (p.track for p in self.discard_set.all()),
-            )
-        )
+        playlist = self.playlist()
+        return [
+            p.track for p in self.discard_set.all()
+            if p.track not in playlist
+        ]
 
     @memoize
     @pk_cached(20)