Merge create_type_dag handler with create_reference handler
#1147
+323
−460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
taichi-ishitani
force-pushed
the
merge_reference_and_type_dag
branch
6 times, most recently
from
6557d91 to
e18356b
Compare
taichi-ishitani
changed the title
create_reference and create_type_dag handlerscreate_type_dag handler with create_reference handler
taichi-ishitani
force-pushed
the
merge_reference_and_type_dag
branch
from
e18356b to
25a28d5
Compare
dalance
reviewed
Dec 16, 2024
| @@ -166,6 +325,132 @@ impl Handler for CreateReference<'_> { | |||
| } | |||
|
|
|||
| impl VerylGrammarTrait for CreateReference<'_> { | |||
| fn veryl(&mut self, arg: &Veryl) -> Result<(), ParolError> { | |||
There was a problem hiding this comment.
How about following the function order of VerylGrammarTrait implementation.
There was a problem hiding this comment.
I changed function order.
taichi-ishitani
force-pushed
the
merge_reference_and_type_dag
branch
from
25a28d5 to
014b2f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #1131, resolved generic parameters are needed when building type dag and this is achieved by building tyep dag at same time resolving generic parameters.
This PR is to merge
create_type_taghandler withcreate_referecnehandler for this purpose.fix #1131
fix #1070