Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support port default value #1164

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

taichi-ishitani
Copy link
Contributor

@taichi-ishitani taichi-ishitani commented Dec 25, 2024

This PR is to add port default value support.
We can specify a default value which is used when the connection to this port is omitted.
Currenlty, following factors can be used for a port defualt value.

  • For input port
    • literal
    • const defined in a package
  • For output port (module)
    • anonymous identifier
    • this port is opened if connection is omitted
  • For output port (function)
    • Not allowed
  • For other ports
    • Not allowed

close #1086

@taichi-ishitani taichi-ishitani force-pushed the default_port_value branch 4 times, most recently from 90eeab3 to 9f57ab1 Compare December 26, 2024 07:55
Copy link

codspeed-hq bot commented Dec 26, 2024

CodSpeed Performance Report

Merging #1164 will not alter performance

Comparing taichi-ishitani:default_port_value (d0e303f) with master (1bff7d0)

Summary

✅ 3 untouched benchmarks

@dalance dalance added the enhancement New feature or request label Dec 26, 2024
@dalance dalance merged commit a34ee69 into veryl-lang:master Dec 26, 2024
9 checks passed
@taichi-ishitani taichi-ishitani deleted the default_port_value branch December 26, 2024 09:28
@dalance dalance added this to the v0.13.4 milestone Dec 27, 2024
This was referenced Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow to specify default value to input/output port
2 participants