This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
raft heartbeat in eb #497
Merged
raft heartbeat in eb #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
dutor,
yixinglu,
darionyaphet,
CPWstatic,
liuyu85cn,
bright-starry-sky,
panda-sheep and
a team
|
|
liuyu85cn
approved these changes
Jun 23, 2021
bright-starry-sky
approved these changes
Jun 23, 2021
This was referenced Jun 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some digging,
process_in_event_basehas no effect for both previous and current version fbthrift, all requests received from io thread will be handled worker thread. If request do need to process in eb, need to removeprocess_in_event_baseand add annotation.Storage PR will be opened later.