fix: metric unit layout (#152)

vesoft-inc · Oct 31, 2022 · 4cc63d6 · 4cc63d6
1 parent 1b771ef
commit 4cc63d6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/pages/MachineDashboard/Detail/index.tsx b/src/pages/MachineDashboard/Detail/index.tsx
@@ -96,7 +96,7 @@ function Detail(props: IProps) {
 
   useEffect(() => {
     updateChart();
-  }, [metricsFilterValues.instanceList, dataSources])
+  }, [metricsFilterValues.instanceList, dataSources, curMetricOptions])
 
   useEffect(() => () => {
     if (pollingTimer) {
@@ -173,6 +173,9 @@ function Detail(props: IProps) {
       const values = data.map(d => d.value) as number[];
       const maxNum = values.length > 0 ? Math.floor(Math.max(...values) * 100) / 100 : undefined;
       const minNum = values.length > 0 ? Math.floor(Math.min(...values) * 100) / 100 : undefined;
+      if (chart.metric.metric === 'disk_writebytes') {
+        debugger;
+      }
       chart.chartRef.updateDetailChart({
         type,
         valueType: chart.metric.valueType,
@@ -250,7 +253,7 @@ function Detail(props: IProps) {
                 <div className='chart-content'>
                   <LineChart
                     baseLine={metricChart.baseLine}
-                    options={{ padding: [10, 70, 70, 70] }}
+                    // options={{ padding: [10, 70, 70, 70] }}
                     ref={ref => metricChart.chartRef = ref}
                     renderChart={renderChart(i)}
                   />

diff --git a/src/pages/ServiceDashboard/Detail/index.tsx b/src/pages/ServiceDashboard/Detail/index.tsx
@@ -190,7 +190,7 @@ function ServiceDetail(props: IProps) {
   useEffect(() => {
     if (dataSources.length === 0) return;
     updateChart();
-  }, [metricsFilterValues.instanceList, dataSources])
+  }, [metricsFilterValues.instanceList, dataSources, curMetricOptions])
 
   const asyncGetMetricsData = async () => {
     const { timeRange, period, space, metricType } = metricsFilterValues;
@@ -355,7 +355,7 @@ function ServiceDetail(props: IProps) {
                   <div className='chart-content'>
                     <LineChart
                       // baseLine={metricChart.baseLine}
-                      options={{ padding: [20, 20, 60, 50] }}
+                      // options={{ padding: [20, 20, 60, 50] }}
                       ref={ref => metricChart.chartRef = ref}
                       renderChart={renderChart(i)}
                     />