Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tagless for sst file #98

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Sep 26, 2022

test process using basketball player vertex data:

  1. generate sst files
  2. download & ingest
  3. query vertex with match (v) where id(v) == "player100" return id(v), there is some result for player100
  4. drop tag player
  5. query vertex with match (v) where id(v) == "player100" return id(v), there is no result for player100

@Nicole00 Nicole00 added the ready-for-testing PR: ready for the CI test label Sep 26, 2022
@Nicole00
Copy link
Contributor Author

@shanlai please feel free to test it, thanks

@codecov-commenter
Copy link

Codecov Report

Base: 55.42% // Head: 55.42% // No change to project coverage 👍

Coverage data is based on head (eeab08e) compared to base (4edf6ce).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #98   +/-   ##
=========================================
  Coverage     55.42%   55.42%           
  Complexity       81       81           
=========================================
  Files            17       17           
  Lines          1411     1411           
  Branches        267      267           
=========================================
  Hits            782      782           
  Misses          489      489           
  Partials        140      140           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 merged commit 775f7e7 into vesoft-inc:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants