Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add close for connect provider & refactor ssl name #31

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

Nicole00
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #31 (5ef85a0) into master (c8d25d6) will decrease coverage by 0.59%.
The diff coverage is 51.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
- Coverage     40.43%   39.83%   -0.60%     
  Complexity      142      142              
============================================
  Files            46       46              
  Lines          1365     1373       +8     
  Branches        124      128       +4     
============================================
- Hits            552      547       -5     
- Misses          765      776      +11     
- Partials         48       50       +2     
Impacted Files Coverage Δ
...connector/nebula/sink/NebulaBatchOutputFormat.java 45.16% <0.00%> (-3.97%) ⬇️
...bula/connection/NebulaGraphConnectionProvider.java 71.42% <50.00%> (-5.50%) ⬇️
...nnector/nebula/connection/NebulaClientOptions.java 81.08% <75.00%> (-7.97%) ⬇️
...ache.flink/connector/nebula/utils/SSLSighType.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d25d6...5ef85a0. Read the comment docs.

@Nicole00 Nicole00 merged commit 6541047 into vesoft-inc:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants