expose ResultSet #282
Merged
expose ResultSet #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 62.12% 62.04% -0.09%
==========================================
Files 9 9
Lines 2305 2308 +3
==========================================
Hits 1432 1432
- Misses 734 737 +3
Partials 139 139
☔ View full report in Codecov by Sentry. |
HarrisChu
previously approved these changes
Aug 22, 2023
Nicole00
commented
Aug 22, 2023
| @@ -94,6 +94,11 @@ const ( | |||
| ErrorCode_E_PARTIAL_SUCCEEDED ErrorCode = ErrorCode(nebula.ErrorCode_E_PARTIAL_SUCCEEDED) | |||
| ) | |||
|
|
|||
| func GenResultSet(resp *graph.ExecutionResponse) (*ResultSet, error) { | |||
| var defaultTimezone timezoneInfo = timezoneInfo{0, []byte("UTC")} | |||
There was a problem hiding this comment.
please help to check the default timezoneInfo @wenhaocs
xtcyclist
approved these changes
Aug 22, 2023
wenhaocs
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #281