Add example code for using ResultSet Scan #303
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
==========================================
- Coverage 63.37% 63.27% -0.11%
==========================================
Files 9 9
Lines 2452 2456 +4
==========================================
Hits 1554 1554
- Misses 768 772 +4
Partials 130 130 ☔ View full report in Codecov by Sentry. |
|
cc @Nicole00 |
result_set.go
Outdated
| @@ -336,31 +336,35 @@ func (res ResultSet) Scan(v interface{}) error { | |||
|
|
|||
| // Scan scans the rows into the given value. | |||
| func (res ResultSet) scanRow(row *nebula.Row, colNames []string, t reflect.Type) (reflect.Value, error) { | |||
| rowValues := row.GetValues() | |||
| rowVals := row.GetValues() | |||
|
|
|||
| val := reflect.New(t).Elem() | |||
|
|
|||
haoxins
dismissed
wey-gu’s stale review
The merge-base changed after approval.
| case reflect.Int64: | ||
| val.Field(fIdx).SetInt(rowVal.GetIVal()) | ||
| case reflect.Float64: | ||
| val.Field(fIdx).SetFloat(rowVal.GetFVal()) |
There was a problem hiding this comment.
don't we need to process bool/float32/int8/int16/date/datetime/time/duration/?
There was a problem hiding this comment.
we need, but I will open another PR to do this.
Also we need enhance/refactor the tests.
this is just make the example works.
|
BTW, the examples are also complex for the starters. |
Thanks so much @haoxins , you are making NebulaGraph/ NebulaGraph community a lot better 🫡. |
deps #305
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: