Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Commit

Permalink
fix the bug create space on group v2
Browse files Browse the repository at this point in the history
  • Loading branch information
tongheihei committed Jun 23, 2021
2 parents 034922b + d3508a9 commit 938c04e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
8 changes: 0 additions & 8 deletions src/parser/AdminSentences.h
Original file line number Diff line number Diff line change
Expand Up @@ -336,14 +336,6 @@ class CreateSpaceSentence final : public CreateSentence {
groupName_.reset(name);
}

const std::string* groupName() const {
return groupName_.get();
}

const SpaceOptList* spaceOpts() const {
return spaceOpts_.get();
}

void setComment(std::string *name) {
comment_.reset(name);
}
Expand Down
3 changes: 0 additions & 3 deletions src/validator/AdminValidator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ Status CreateSpaceValidator::validateImpl() {
}
}
}
<<<<<<< HEAD
// check comment
if (sentence->comment() != nullptr) {
spaceDesc_.set_comment(*sentence->comment());
Expand All @@ -116,8 +115,6 @@ Status CreateSpaceValidator::validateImpl() {
return Status::SemanticError("Group default conflict");
}

=======
>>>>>>> fix create space on group
// if charset and collate are not specified, set default value
if (!(*spaceDesc_.charset_name_ref()).empty() && !(*spaceDesc_.collate_name_ref()).empty()) {
NG_RETURN_IF_ERROR(charsetInfo->charsetAndCollateMatch(*spaceDesc_.charset_name_ref(),
Expand Down

0 comments on commit 938c04e

Please sign in to comment.