Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

[issue 1066]: enhance service script to return version information for '-v' option #1230

Merged
merged 3 commits into from
Jul 14, 2021
Merged

[issue 1066]: enhance service script to return version information for '-v' option #1230

merged 3 commits into from
Jul 14, 2021

Conversation

jtcheng
Copy link
Contributor

@jtcheng jtcheng commented Jul 9, 2021

Fix issue: #1066

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jtcheng
Copy link
Contributor Author

jtcheng commented Jul 9, 2021

status command without '-v' option:

jtcheng@wattles1:/usr/local/nebula/scripts$ ./nebula.service status all
[INFO] nebula-metad: Running as 10926, Listening on 9559
[INFO] nebula-graphd: Running as 11017, Listening on 9669
[INFO] nebula-storaged: Running as 11068, Listening on 9779

status command with '-v' option:

jtcheng@wattles1:/usr/local/nebula/scripts$ ./nebula.service -v status all
[INFO] nebula-metad version Git: 977a9cbc: Running as 10926, Listening on 9559
[INFO] nebula-graphd version Git: 977a9cbc: Running as 11017, Listening on 9669
[INFO] nebula-storaged version Git: 977a9cbc: Running as 11068, Listening on 9779

yixinglu
yixinglu reviewed Jul 13, 2021
View reviewed changes
scripts/nebula.service Outdated Show resolved Hide resolved
@jtcheng jtcheng requested a review from yixinglu July 14, 2021 04:12
@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Jul 14, 2021
@CPWstatic
Copy link
Contributor

LGTM.

@yixinglu yixinglu linked an issue Jul 14, 2021 that may be closed by this pull request
-v does not return version information #1066
Closed
@yixinglu yixinglu merged commit 5540604 into vesoft-inc:master Jul 14, 2021
@jtcheng jtcheng deleted the enhancement/service_version branch July 14, 2021 09:49
@jamieliu1023 jamieliu1023 mentioned this pull request Jul 17, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@critical27 critical27 critical27 approved these changes

@bright-starry-sky bright-starry-sky Awaiting requested review from bright-starry-sky

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@laura-ding laura-ding Awaiting requested review from laura-ding

@Shylock-Hg Shylock-Hg Awaiting requested review from Shylock-Hg

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-v does not return version information
6 participants
@jtcheng @CLAassistant @CPWstatic @yixinglu @critical27 @jievince