maybe should check the result of filepath.Glob() and return an error #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LooJee
changed the title
|
I've seen the refactor pr, maybe I should close mine? |
veezhang
reviewed
May 11, 2023
pkg/config/config.go
Outdated
Comment on lines
409
to
412
| if len(fileNames) == 0 && err == nil { | ||
| err = fmt.Errorf("file: %s doesn't exist", *f.Path) | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
How about?
if err != nil {
return err
}
if len(fileNames) == 0 {
return &os.PathError{Op: "open", Path: *f.Path, Err: fs.ErrNotExist}
}There was a problem hiding this comment.
it will be much better, I will resolve it promptly.
There was a problem hiding this comment.
@veezhang I have improved it， please check it again.
There was a problem hiding this comment.
@LooJee Good job!
Sorry, I find the ci is use go1.13, so maybe you should use os.ErrNotExist instead of fs.ErrNotExist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
filepath.Glob() won't return an error while files don't exist, maybe here should have an error. Because the expandFiles() will return an empty []*File, and the error is nil. Then the yaml.Files at cmd/runner.go/Run() will be an empty slice, then the statsMgr never receive a done signal.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: