Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule optimization #369

Merged
merged 1 commit into from
Oct 24, 2023
Merged

schedule optimization #369

merged 1 commit into from
Oct 24, 2023

Conversation

MegaByte875
Copy link
Contributor

@MegaByte875 MegaByte875 commented Oct 23, 2023 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

This was referenced Oct 23, 2023
Closed
Closed
@MegaByte875
Copy link
Contributor Author

Current:

$ kubectl get cm nebula-graphd-zone -o yaml
apiVersion: v1
data:
  nebula-graphd: ""
  nebula-graphd-0: az2
  nebula-graphd-1: az3
  nebula-graphd-2: az1
  nebula-graphd-3: az1
  nebula-graphd-4: az2
  nebula-graphd-5: az2
  nebula-graphd-6: az3
  nebula-graphd-7: az1
  nebula-graphd-8: az3
  nebula-graphd-9: az3
  nebula-graphd-10: az2
  nebula-graphd-11: az1
  nebula-graphd-12: az1
  nebula-graphd-13: az2
  nebula-graphd-14: az3
  nebula-graphd-15: az2
  nebula-graphd-16: az1
  nebula-graphd-17: az3
  nebula-graphd-18: az2
  nebula-graphd-19: az3

After optimization:

$ kubectl get cm nebula-graphd-zone -o yaml
apiVersion: v1
data:
  nebula-graphd: ""
  nebula-graphd-0: az2
  nebula-graphd-1: az3
  nebula-graphd-2: az1
  nebula-graphd-3: az2
  nebula-graphd-4: az3
  nebula-graphd-5: az1
  nebula-graphd-6: az2
  nebula-graphd-7: az3
  nebula-graphd-8: az1
  nebula-graphd-9: az2
  nebula-graphd-10: az3
  nebula-graphd-11: az1
  nebula-graphd-12: az1
  nebula-graphd-14: az3
  nebula-graphd-15: az2
  nebula-graphd-16: az3
  nebula-graphd-17: az1
  nebula-graphd-18: az2
  nebula-graphd-19: az3

kqzh
kqzh approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@kqzh kqzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wenhaocs
wenhaocs reviewed Oct 23, 2023
View reviewed changes
pkg/scheduler/nodezone/node_zone.go
// Name is the name of the plugin used in the plugin registry and configurations.
Name = "NodeZone"

// AvailableZones is the number failure domains over which we should spread.
AvailableZones = 3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 3 is the minimum value to ensure HA on cloud.

@MegaByte875 MegaByte875 merged commit 824a12a into vesoft-inc:master Oct 24, 2023
@MegaByte875 MegaByte875 deleted the scheduler branch November 21, 2023 07:07
MegaByte875 added a commit to MegaByte875/nebula-operator that referenced this pull request Nov 21, 2023
@MegaByte875
schedule optimization (vesoft-inc#369)
a46a6ae 
(cherry picked from commit 824a12a)
MegaByte875 added a commit that referenced this pull request Nov 21, 2023
@MegaByte875
cherry-pick schedule optimization (#369) (#401)
7621ef0 
schedule optimization (#369)

(cherry picked from commit 824a12a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenhaocs wenhaocs wenhaocs left review comments

@kqzh kqzh kqzh approved these changes

@veezhang veezhang Awaiting requested review from veezhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MegaByte875 @wenhaocs @kqzh