Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngctl: Nebula Graph Kubernetes Control #38

Merged
merged 1 commit into from
Jul 2, 2021
Merged

ngctl: Nebula Graph Kubernetes Control #38

merged 1 commit into from
Jul 2, 2021

Conversation

veezhang
Copy link
Contributor

@veezhang veezhang commented Jul 1, 2021 •
edited by kqzh
Loading

  • cmd framework
  • version
  • use
  • list
  • info
  • console
  • debug
  • doc

@veezhang veezhang requested review from MegaByte875 and kqzh July 1, 2021 04:47
@veezhang
Copy link
Contributor Author

veezhang commented Jul 1, 2021

Fix: #32

kqzh
kqzh reviewed Jul 1, 2021
View reviewed changes
pkg/ngctl/cmd/cmd.go Outdated
`
)

func NewNkctlCmd(in io.Reader, out, err io.Writer) *cobra.Command {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this function like NewNgctlCmd will be better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emm, u r right!

@veezhang veezhang added type/feature req Type: feature request ready-for-testing Progress: ready for the CI test labels Jul 1, 2021
kqzh
kqzh reviewed Jul 1, 2021
View reviewed changes
pkg/ngctl/cmd/version/version.go
o := NewOptions(ioStreams)
cmd := &cobra.Command{
Use: "version",
Short: "Print the cli and nebula operator version",
Copy link
Contributor

@kqzh kqzh Jul 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Long: "Print the cli and nebula operator version", it's better than Long == ""

@kqzh kqzh merged commit 777cf5e into vesoft-inc:master Jul 2, 2021
@wey-gu
Copy link
Contributor

wey-gu commented Jul 2, 2021

Cheers!!!

@jamieliu1023 jamieliu1023 mentioned this pull request Jul 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqzh kqzh kqzh approved these changes

@MegaByte875 MegaByte875 Awaiting requested review from MegaByte875

Assignees
No one assigned
Labels
ready-for-testing Progress: ready for the CI test type/feature req Type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veezhang @wey-gu @kqzh