Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken link in the changelog #173

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

greyli
Copy link
Contributor

@greyli greyli commented Nov 10, 2021

No description provided.

@greyli
Copy link
Contributor Author

greyli commented Nov 11, 2021

Hi @Aiee, I notice #172 also addresses this issue, but it shouldn't correct the typo word "propertys" since you can't correct properties to properties (it's a change log for typo fix). So I recommend merging this PR then restoring the change to the changelog file in #172.

@HarrisChu
Copy link
Contributor

good job!

@jsoref jsoref mentioned this pull request Nov 11, 2021
@Aiee Aiee merged commit 0426eb9 into vesoft-inc:master Nov 15, 2021
@greyli greyli deleted the patch-1 branch November 15, 2021 05:54
Aiee pushed a commit to jsoref/nebula-python that referenced this pull request Nov 23, 2021
Aiee added a commit that referenced this pull request Nov 25, 2021
* spelling: command-line

* spelling: connects

* spelling: contain

* spelling: directly

* spelling: encountered

* spelling: factory

* spelling: future

* spelling: happen

* spelling: present

* spelling: properties https

* spelling: properties to

* spelling: properties

* spelling: service

* spelling: specific

* spelling: timeout

* spelling: transport

* spelling: value

* spelling: values of

* spelling: wrapper

* Fix a broken link in the changelog (#173)

* Update thrift files (#177)

* Update thirift files

* Fix ci

* enhance

* ignore scan data by next cusor

* Remove code for testing

Co-authored-by: HarrisChu <1726587+HarrisChu@users.noreply.github.com>

* Fix ci

* Format

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Grey Li <withlihui@gmail.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Co-authored-by: HarrisChu <1726587+HarrisChu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants