Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ValueWrapper.cast support __EMPTY__ type #269

Merged
merged 3 commits into from
Jun 14, 2023
Merged

fix: ValueWrapper.cast support __EMPTY__ type #269

merged 3 commits into from
Jun 14, 2023

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Mar 27, 2023

it now calls as_empty which doesn't exist.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

n/a

Description:

Previously it could not handle empty properly.

How do you solve it?

  • Removed the as_empty call from the attribute map
  • return None when it's empty

it now calls as_empty which doesn't exist.
@wey-gu wey-gu requested review from Aiee and HarrisChu March 27, 2023 02:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (6e5742f) 77.62% compared to head (df081f3) 77.60%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   77.62%   77.60%   -0.03%     
==========================================
  Files          18       18              
  Lines        2409     2411       +2     
==========================================
+ Hits         1870     1871       +1     
- Misses        539      540       +1     
Impacted Files Coverage Δ
nebula3/data/DataObject.py 76.35% <50.00%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wey-gu wey-gu mentioned this pull request Jun 13, 2023
3 tasks
@Aiee Aiee merged commit fda4738 into master Jun 14, 2023
@Aiee Aiee deleted the cast_fix_empty branch June 14, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants