Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: primitive params #351

Merged
merged 9 commits into from
Jul 15, 2024
Merged

feat: primitive params #351

merged 9 commits into from
Jul 15, 2024

Conversation

BeautyyuYanli
Copy link
Contributor

Updatet execute_py

  • Return result as python object List[Dict[str, Any]]
  • Raise exceptions

@wey-gu
Copy link
Contributor

wey-gu commented May 30, 2024

  • maybe it can reuse resultSet.as_primitive()?
  • return raw resultSet can be optional(default false)?

@BeautyyuYanli
Copy link
Contributor Author

BeautyyuYanli commented May 31, 2024 •
edited
Loading

return raw resultSet can be optional(default false)?

Typing would be dirty because Python<=3.7 doesn't support things to do override. So I just return the ResultSet.

@wey-gu wey-gu added the doc affected PR: improvements or additions to documentation label Jul 15, 2024
@wey-gu wey-gu changed the title Update execute_py feat: primitive params Jul 15, 2024
@wey-gu
Copy link
Contributor

wey-gu commented Jul 15, 2024

docs: #352

@wey-gu wey-gu merged commit f1b75ce into master Jul 15, 2024
10 checks passed
@wey-gu wey-gu deleted the yanli/update_execute_py branch July 15, 2024 05:39
wey-gu added a commit that referenced this pull request Jul 16, 2024
@BeautyyuYanli @wey-gu
feat: primitive params (#351)
98668e7 
feat: primitive params

---------

Co-authored-by: Wey Gu <weyl.gu@gmail.com>
@wey-gu wey-gu mentioned this pull request Jul 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wey-gu wey-gu wey-gu approved these changes

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeautyyuYanli @wey-gu