Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup sentence #1705

Merged
merged 27 commits into from
Feb 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d94d0b3
online index scan
Dec 9, 2019
90b745c
To improve the PR, 1: Using kIndex instead of kData. 2: Removed kInde…
Dec 16, 2019
73e0c69
1,Resolve conflict. 2, Directory structure refactoring
Dec 23, 2019
edbd590
1,Reconcile pr1360; 2,Disable the data query when return columns are …
Dec 27, 2019
02c75cb
Remove 'type' from IndexHintItem
Dec 30, 2019
bf24862
Resolve conflict
Dec 31, 2019
89adf63
1, Addressed comments. 2, Optimized index scan logic.
Jan 9, 2020
d93201c
1, Addressed comments. 2, Optimized index scan logic.
Jan 11, 2020
aa31d21
1, Addressed comments. 2, Optimized index scan logic.
Jan 11, 2020
9e1f36e
Add some comments.
Jan 16, 2020
19635f1
Added testcases
Jan 16, 2020
bfe96de
1,Addressed comments, 2, Improving the traversal logic of expressions…
Jan 17, 2020
cab3ca5
1,Addressed comments, 2, Resolved conflicts
Jan 17, 2020
dba2ac4
1,Addressed comments. 2,Simplify policy generation
Jan 20, 2020
d376827
fixed bug for empty prop value
Jan 20, 2020
c7b6985
lookup
Jan 31, 2020
69524a4
Add testcase
Feb 5, 2020
043d4a6
Add testcase for condition filter
Feb 6, 2020
6653319
Resolve conflict
Feb 6, 2020
fcc7477
Addressed laura-ding's comment
Feb 7, 2020
ab1cedb
fixed bug for console output
Feb 7, 2020
dcd2424
Addressed dangleptr's comments
Feb 10, 2020
afd1a4a
Add expression check to avoid memory leak
Feb 12, 2020
cf79eba
Resolve conflict
Feb 17, 2020
9558ca7
Addressed dangleptr's comments
Feb 17, 2020
65cfd71
addressed dangleptr's comment
Feb 18, 2020
c2519a8
Addressed panda-sheep's comment
Feb 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/common/base/test/NebulaKeyUtilsTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,15 @@ TEST(NebulaKeyUtilsTest, encodeVariant) {
EXPECT_TRUE(evalDouble(-(0.000000001 - std::numeric_limits<double>::min())));
}

TEST(NebulaKeyUtilsTest, encodeDouble) {
EXPECT_TRUE(evalDouble(100.5));
EXPECT_TRUE(evalDouble(200.5));
EXPECT_TRUE(evalDouble(300.5));
EXPECT_TRUE(evalDouble(400.5));
EXPECT_TRUE(evalDouble(500.5));
EXPECT_TRUE(evalDouble(600.5));
}

} // namespace nebula


Expand Down
2 changes: 1 addition & 1 deletion src/graph/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ nebula_add_library(
FetchEdgesExecutor.cpp
FetchExecutor.cpp
SetExecutor.cpp
FindExecutor.cpp
MatchExecutor.cpp
DeleteVertexExecutor.cpp
DeleteEdgesExecutor.cpp
Expand All @@ -62,6 +61,7 @@ nebula_add_library(
CreateSnapshotExecutor.cpp
DropSnapshotExecutor.cpp
AdminJobExecutor.cpp
LookupExecutor.cpp
)
nebula_add_subdirectory(test)

6 changes: 3 additions & 3 deletions src/graph/Executor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
#include "graph/FetchEdgesExecutor.h"
#include "graph/ConfigExecutor.h"
#include "graph/SetExecutor.h"
#include "graph/FindExecutor.h"
#include "graph/LookupExecutor.h"
#include "graph/MatchExecutor.h"
#include "graph/BalanceExecutor.h"
#include "graph/DeleteVertexExecutor.h"
Expand Down Expand Up @@ -175,8 +175,8 @@ std::unique_ptr<Executor> Executor::makeExecutor(Sentence *sentence) {
case Sentence::Kind::kMatch:
executor = std::make_unique<MatchExecutor>(sentence, ectx());
break;
case Sentence::Kind::kFind:
executor = std::make_unique<FindExecutor>(sentence, ectx());
case Sentence::Kind::kLookup:
executor = std::make_unique<LookupExecutor>(sentence, ectx());
break;
case Sentence::Kind::kBalance:
executor = std::make_unique<BalanceExecutor>(sentence, ectx());
Expand Down
24 changes: 0 additions & 24 deletions src/graph/FindExecutor.cpp

This file was deleted.

40 changes: 0 additions & 40 deletions src/graph/FindExecutor.h

This file was deleted.

Loading