Push down filters in reversely or bidirectional traverse. #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPWstatic
force-pushed
the
pushdown_filter_any_direction_traverse
branch
from
66a9f9b to
d784b25
Compare
CPWstatic
force-pushed
the
pushdown_filter_any_direction_traverse
branch
from
d784b25 to
c1e9708
Compare
|
This is a great improvement. Do we want it in 1.x, IMO we should accept it. |
critical27
reviewed
Jul 20, 2020
| if (value.ok() && !Expression::asBool(value.value())) { | ||
| VLOG(1) << "Filter the edge " | ||
| << vId << "-> " << dstId << "@" << rank << ":" << edgeType; | ||
| continue; |
There was a problem hiding this comment.
if value is not ok, need to continue as well
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.