Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the oct number representation to with 0o prefix. #2014

Closed
wants to merge 1 commit into from
Closed

Optimize the oct number representation to with 0o prefix. #2014

wants to merge 1 commit into from

Conversation

Shylock-Hg
Copy link
Contributor

What changes were proposed in this pull request?

See #1940

Why are the changes needed?

Does this PR introduce any user-facing change?

Yes @Amber1990Zhang

How was this patch tested?

@Shylock-Hg Shylock-Hg added the incompatible PR: incompatible with the recently released version label Mar 30, 2020
@Shylock-Hg Shylock-Hg linked an issue Mar 30, 2020 that may be closed by this pull request
@Shylock-Hg Shylock-Hg added nGQL ready-for-testing PR: ready for the CI test labels Mar 30, 2020
@codecov-io
Copy link

Codecov Report

Merging #2014 into master will decrease coverage by 0.18%.
The diff coverage is 94.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
- Coverage   86.90%   86.71%   -0.19%     
==========================================
  Files         636      642       +6     
  Lines       59819    60902    +1083     
==========================================
+ Hits        51984    52811     +827     
- Misses       7835     8091     +256     
Impacted Files Coverage Δ
src/common/base/Configuration.h 100.00% <ø> (ø)
src/graph/DescribeSpaceExecutor.h 0.00% <ø> (ø)
src/graph/FetchEdgesExecutor.h 0.00% <ø> (ø)
src/graph/FetchExecutor.cpp 87.77% <ø> (-0.53%) ⬇️
src/graph/FetchVerticesExecutor.h 0.00% <ø> (ø)
src/graph/GoExecutor.h 56.25% <ø> (ø)
src/graph/GraphService.h 100.00% <ø> (ø)
src/graph/GroupByExecutor.cpp 85.25% <ø> (-0.06%) ⬇️
src/graph/LimitExecutor.cpp 68.60% <ø> (-0.37%) ⬇️
src/graph/OrderByExecutor.cpp 75.18% <ø> (-0.19%) ⬇️
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d838d4...938bbc1. Read the comment docs.

@dangleptr
Copy link
Contributor

The behavior has been changed inside this pr.
Do we still want it in 1.x? @whitewum @jude-zhu

@jude-zhu
Copy link
Contributor

I think indicating an octal literal by prepending it with 0 is fine. BTW. 0 is still employed to indicate octal literal in Nebula 2.0.

FYI. same with neo4j

@dangleptr
Copy link
Contributor

I think indicating an octal literal by prepending it with 0 is fine. BTW. 0 is still employed to indicate octal literal in Nebula 2.0.

FYI. same with neo4j

Fine. Please take care of the issue related. Let me close this pr. Thanks

@dangleptr dangleptr closed this Jul 15, 2020
@Shylock-Hg
Copy link
Contributor Author

I think indicating an octal literal by prepending it with 0 is fine. BTW. 0 is still employed to indicate octal literal in Nebula 2.0.

FYI. same with neo4j

Reservations

yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octal with zero prefix is not a good design.
5 participants