Try to use whole key bloom filter when insert data with index #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
dangleptr,
liuyu85cn,
bright-starry-sky and
panda-sheep
Codecov Report
@@ Coverage Diff @@
## master #2377 +/- ##
==========================================
- Coverage 86.46% 86.25% -0.21%
==========================================
Files 649 648 -1
Lines 64374 65622 +1248
==========================================
+ Hits 55662 56604 +942
- Misses 8712 9018 +306
Continue to review full report at Codecov.
|
bright-starry-sky
approved these changes
Oct 26, 2020
liuyu85cn
approved these changes
Oct 27, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…-inc#2377) * use bloom filter if available * add ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, since the default value of enable_multi_versions is false, we could use the bloom filter to avoid extra disk read if the newly insert data does not exist.