add code coverage #2884
Merged
add code coverage #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HarrisChu
commented
Sep 16, 2021
•
HarrisChu
commented
- add lcov for coverage nebula-dev-docker#57, waiting for this pr merged.
- need to verify codecov.io no need token via github action.
yixinglu
reviewed
Sep 16, 2021
yixinglu
previously approved these changes
Sep 17, 2021
|
@HarrisChu it seems that you shoud install |
HarrisChu
force-pushed
the
add_tck_coverage
branch
from
01d5f6e
to
59ce518
Compare
|
it's ok now, https://codecov.io/gh/vesoft-inc/nebula/tree/f506b6ef68c4e415903496160390e6fe656e3b41 but seems if there's any failed job, it won't display codecov bot in conversation |
HarrisChu
force-pushed
the
add_tck_coverage
branch
from
767da90
to
ad64f67
Compare
yixinglu
approved these changes
Sep 23, 2021
jievince
approved these changes
Sep 23, 2021
This was referenced Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.