describe the user #3300
describe the user #3300
Conversation
|
|
Sophie-Xie
requested review from
yixinglu,
Shylock-Hg and
CPWstatic
and removed request for
yixinglu
done |
| @@ -2714,6 +2723,7 @@ traverse_sentence | |||
| | delete_edge_sentence { $$ = $1; } | |||
| | show_queries_sentence { $$ = $1; } | |||
| | kill_query_sentence { $$ = $1; } | |||
| | describe_user_sentence { $$ = $1; } | |||
There was a problem hiding this comment.
The traverse_sentence means supporting input/output. Don't put it here.
There was a problem hiding this comment.
The desc_user_sentcence supports output pipe.
There was a problem hiding this comment.
Why need this? Normally, admin sentence don't support it.
There was a problem hiding this comment.
To Support desc user user1 | YIELD $-.role where $-.space == "space3"
There was a problem hiding this comment.
Does this pass in discussion meeting?
There was a problem hiding this comment.
@yixinglu From Yee‘s conversation
Codecov Report
@@ Coverage Diff @@
## master #3300 +/- ##
==========================================
- Coverage 85.31% 85.26% -0.05%
==========================================
Files 1289 1279 -10
Lines 120073 118989 -1084
==========================================
- Hits 102442 101459 -983
+ Misses 17631 17530 -101
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
LGMT except allowing input/output. How do you think about it? @CPWstatic
| | "ADMIN" | "user_tmp_space_4" | | ||
| When executing query: | ||
| """ | ||
| DESC USER user1 | YIELD $-.space as sp |
There was a problem hiding this comment.
Maybe more tests about: SHOW USERS | DESC USER $-.Account
What type of PR is this?
What does this PR do?
$ desc user endy
+---------+------------------------------------+
| Account | Roles in spaces |
+---------+------------------------------------+
| "endy" | " USER in nba, USER in my_space_1" |
+---------+------------------------------------+
Got 1 rows (time spent 1319/6278 us)
Which issue(s)/PR(s) this PR relates to?
how to describe the user? #2574
#2574
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: