Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo error of KW_VALUE #3303

Merged
merged 1 commit into from
Nov 15, 2021
Merged

fix typo error of KW_VALUE #3303

merged 1 commit into from
Nov 15, 2021

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Nov 11, 2021

Fix #2204

@jievince jievince added type/bug Type: something is unexpected incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test labels Nov 11, 2021
yixinglu
yixinglu previously approved these changes Nov 11, 2021
Shylock-Hg
Shylock-Hg previously approved these changes Nov 11, 2021
@jievince jievince dismissed stale reviews from Shylock-Hg and yixinglu via 778461b November 11, 2021 09:07
@jievince jievince force-pushed the value-typo branch 2 times, most recently from 778461b to 607aa58 Compare November 11, 2021 09:07
czpmango
czpmango previously approved these changes Nov 11, 2021
yixinglu
yixinglu previously approved these changes Nov 12, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3303 (df1f53c) into master (8e0028f) will decrease coverage by 0.02%.
The diff coverage is 81.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
- Coverage   85.29%   85.27%   -0.03%     
==========================================
  Files        1305     1305              
  Lines      120383   120446      +63     
==========================================
+ Hits       102683   102712      +29     
- Misses      17700    17734      +34     
Impacted Files Coverage Δ
src/graph/service/CloudAuthenticator.cpp 0.00% <0.00%> (ø)
...torage/transaction/ChainAddEdgesProcessorLocal.cpp 58.82% <50.00%> (+0.01%) ⬆️
src/clients/meta/MetaClient.cpp 75.42% <82.12%> (+0.45%) ⬆️
src/clients/meta/MetaClient.h 95.65% <100.00%> (+2.31%) ⬆️
src/graph/service/PasswordAuthenticator.cpp 100.00% <100.00%> (ø)
src/graph/service/QueryEngine.h 100.00% <100.00%> (ø)
src/parser/test/ScannerTest.cpp 98.27% <100.00%> (ø)
src/graph/context/Result.cpp 85.00% <0.00%> (-9.45%) ⬇️
src/graph/executor/StorageAccessExecutor.h 66.66% <0.00%> (-8.98%) ⬇️
src/common/thread/GenericWorker.h 92.30% <0.00%> (-3.85%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28776ae...df1f53c. Read the comment docs.

@yixinglu yixinglu merged commit 289aadb into vesoft-inc:master Nov 15, 2021
@jievince jievince deleted the value-typo branch November 15, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when i define a property called "value" or a tag named "value", it will be transformed to "values"
5 participants