Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments and change some log level for storage root / http / kv .. #3700

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Jan 12, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

just add some comments

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

n/a

@liuyu85cn liuyu85cn marked this pull request as ready for review February 18, 2022 03:48
@liuyu85cn liuyu85cn added the ready-for-testing PR: ready for the CI test label Feb 18, 2022
@critical27 critical27 merged commit 49bfaf2 into vesoft-inc:master Feb 28, 2022
@critical27 critical27 deleted the comments-and-log-level branch February 28, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants