add nebula-console package action #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
requested review from
sherman-the-tank,
yixinglu and
dutor
as code owners
czpmango
force-pushed
the
console-pkg
branch
from
efe7d3f
to
7c59a2e
Compare
11 tasks
czpmango
force-pushed
the
console-pkg
branch
from
03c8ee1
to
c66f55d
Compare
yixinglu
reviewed
Feb 16, 2022
czpmango
force-pushed
the
console-pkg
branch
from
31e8c1d
to
5710145
Compare
yixinglu
reviewed
Mar 1, 2022
CMakeLists.txt
Outdated
| @@ -25,6 +25,7 @@ project("Nebula Graph" C CXX) | |||
|
|
|||
| option(ENABLE_PACK_ONE "Whether to package into one" ON) | |||
| option(ENABLE_VERBOSE_BISON "Enable Bison to report state" OFF) | |||
| option(ENABLE_CONSOLE_COMPILATION "Enable nebula-console comppilation" OFF) | |||
|
|
||
| add_custom_command( | ||
| OUTPUT ${CMAKE_BINARY_DIR}/nebula-console | ||
| COMMAND bash ${CMAKE_SOURCE_DIR}/src/console/compile-console.sh ${git_branch} ${CMAKE_BINARY_DIR} |
There was a problem hiding this comment.
what happens if there not exists related branch in nebula-console repo?
There was a problem hiding this comment.
Compilation failed.
There was a problem hiding this comment.
Controlled by the cmake option ENABLE_CONSOLE_COMPILATION.
fix nebula-console cpack fix small change trigger console compile fix typo
jievince
approved these changes
Mar 4, 2022
yixinglu
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#3173
Description:
Package nebula-console into an RPM /deb package through action.
Checklist:
Tests:
Affects:
Release notes: