Rollback vertex key #4629

critical27 · 2022-09-08T02:49:45Z

What type of PR is this?

bug
feature
enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Rollback the vertex key, upgrade tool is removed directly.

There are still two tck cases I think it is wrong:

GoYieldVertexEdge.feature: multi edges over all
Go.feature: multi edges over all

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

Unit test(positive and negative cases)
Function test
Performance test
N/A

Affects:

Documentation affected (Please add the label if documentation needs to be modified.)
Incompatibility (If it breaks the compatibility, please describe it and add the label.）
If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

nevermore3 · 2022-09-20T11:10:12Z

When executing query:
    """
    GO FROM "Paul Gasol" OVER *
    WHERE $$.player.name IS NOT NULL
    YIELD edge as e
    """
  Then the result should be, in any order, with relax comparison:
    | e                                                     |
    | [:like "Paul Gasol"->"Kobe Bryant" @0 {likeness: 90}] |
    | [:like "Paul Gasol"->"Marc Gasol" @0 {likeness: 99}]  |

Since getProp previously returned EMPTY rows, now it return nothing, should use is NULL as filter conditions

i already fix the test case

codecov-commenter · 2022-09-21T02:54:35Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.73%. Comparing base (7d5e93f) to head (9858328).
Report is 471 commits behind head on master.

Files with missing lines	Patch %	Lines
src/storage/exec/GetPropNode.h	11.11%	8 Missing ⚠️
src/storage/CompactionFilter.h	50.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4629      +/-   ##
==========================================
+ Coverage   84.67%   84.73%   +0.05%     
==========================================
  Files        1358     1358              
  Lines      135654   135647       -7     
==========================================
+ Hits       114868   114934      +66     
+ Misses      20786    20713      -73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 545137a.

* Revert "insert vertex key when only vertex and flag is set (#4685)" This reverts commit fff82a6. * Revert "only write vertex key when flag is set or explictly insert vertex (#4680)" This reverts commit a5bed33. * Revert "fix bug (#4675)" This reverts commit cccc014. * Revert "Rollback vertex key (#4629)" This reverts commit 545137a. * wtf * tck format

* Use vertex key only when use_vertex_key is on (#4716) * Revert "insert vertex key when only vertex and flag is set (#4685)" This reverts commit fff82a6. * Revert "only write vertex key when flag is set or explictly insert vertex (#4680)" This reverts commit a5bed33. * Revert "fix bug (#4675)" This reverts commit cccc014. * Revert "Rollback vertex key (#4629)" This reverts commit 545137a. * wtf * tck format * fix job status when all finished (#4717) * fix job name from zone balance to data balance * address wenhui's comment * fix create index if not exists behavior (#4705) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com>

foesa-yang · 2022-10-20T06:21:41Z

vesoft-inc/nebula-docs-cn#2192

## What type of PR is this? - [ ] bug - [ ] feature - [X] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #### Description: PRD of vertex key changed again... Here is the new version of logic: 1. No matter use_vertex_key is on or off, the query result should be consistent with 3.1. 2. If use_vertex_key is on, we will use the vertex key to detect whether the vertex exists, which is the logic in 3.X version. 3. If use_vertex_key is off, we will prefix scan by vertex to detect whether the vertex exists, **which will bring performance regression** 4. We will insert the vertex only when use_vertex_key is on > By default, use_vertex_key is off ## How do you solve it? This PR reverts all related changes before (vesoft-inc#4685 vesoft-inc#4680 vesoft-inc#4675 vesoft-inc#4629), and apply the logic above. Related changes: 1. So the upgrade tool is necessary again, so bring it back. 2. The TCK cases keeps same as before vesoft-inc#4629 ## Special notes for your reviewer, ex. impact of this fix, design document, etc: > Maybe review the last commit is enough ## Checklist: Tests: - [X] Unit test(positive and negative cases) - [ ] Function test - [ ] Performance test - [ ] N/A Affects: - [X] Documentation affected (Please add the label if documentation needs to be modified.) - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.） - [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).) - [ ] Performance impacted: Consumes more CPU/Memory ## Release notes: Please confirm whether to be reflected in release notes and how to describe: > ex. Fixed the bug ..... Migrated from vesoft-inc#4716 Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

critical27 added the do not review PR: not ready for the code review yet label Sep 8, 2022

Sophie-Xie added the doc affected PR: improvements or additions to documentation label Sep 8, 2022

Sophie-Xie assigned foesa-yang Sep 8, 2022

Sophie-Xie added the ready-for-testing PR: ready for the CI test label Sep 14, 2022

critical27 added 3 commits September 20, 2022 13:06

remove upgrade tool

d2364d5

rollback

14a0573

fetch/go/insert tck

8d2b013

critical27 force-pushed the vertex branch from 60dd0fe to ff37424 Compare September 20, 2022 06:23

critical27 added ready for review and removed do not review PR: not ready for the code review yet labels Sep 20, 2022

critical27 force-pushed the vertex branch from ff37424 to 60bed04 Compare September 20, 2022 06:27

Sophie-Xie requested review from cangfengzhs and nevermore3 September 20, 2022 06:37

match tck

393cce5

critical27 force-pushed the vertex branch from c2e7221 to 393cce5 Compare September 20, 2022 07:27

cangfengzhs and others added 3 commits September 20, 2022 16:56

Merge branch 'master' into vertex

b963268

Update GoYieldVertexEdge.feature

b516acb

Update GoYieldVertexEdge.feature

2d1728d

Update GO.feature

52ab79e

nevermore3 previously approved these changes Sep 21, 2022

View reviewed changes

change use_vertex_key to graph_use_vertex_key

35e3773

nevermore3 dismissed their stale review via 35e3773 September 21, 2022 02:01

nevermore3 added 2 commits September 21, 2022 10:01

Update GraphFlags.h

59ce989

Update GraphFlags.cpp

9858328

nevermore3 approved these changes Sep 21, 2022

View reviewed changes

cangfengzhs approved these changes Sep 21, 2022

View reviewed changes

Sophie-Xie merged commit 545137a into vesoft-inc:master Sep 21, 2022

wey-gu mentioned this pull request Sep 24, 2022

Weekly Report 2022-09-23 vesoft-inc/nebula-community#134

Closed

critical27 added a commit to critical27/nebula that referenced this pull request Oct 12, 2022

Revert "Rollback vertex key (vesoft-inc#4629)"

eead688

This reverts commit 545137a.

critical27 mentioned this pull request Oct 12, 2022

Use vertex key only when use_vertex_key is on #4716

Merged

11 tasks

critical27 added a commit to critical27/nebula that referenced this pull request Oct 12, 2022

Revert "Rollback vertex key (vesoft-inc#4629)"

8276d6a

This reverts commit 545137a.

critical27 deleted the vertex branch November 11, 2022 02:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollback vertex key #4629

Rollback vertex key #4629

critical27 commented Sep 8, 2022 •

edited

Loading

nevermore3 commented Sep 20, 2022 •

edited

Loading

codecov-commenter commented Sep 21, 2022 •

edited

Loading

foesa-yang commented Oct 20, 2022

Rollback vertex key #4629

Rollback vertex key #4629

Conversation

critical27 commented Sep 8, 2022 • edited Loading

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Release notes:

nevermore3 commented Sep 20, 2022 • edited Loading

codecov-commenter commented Sep 21, 2022 • edited Loading

Codecov Report

foesa-yang commented Oct 20, 2022

critical27 commented Sep 8, 2022 •

edited

Loading

nevermore3 commented Sep 20, 2022 •

edited

Loading

codecov-commenter commented Sep 21, 2022 •

edited

Loading