Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only create 1 part in tck #4817

Merged
merged 2 commits into from
Nov 3, 2022
Merged

only create 1 part in tck #4817

merged 2 commits into from
Nov 3, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Nov 2, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Backport from https://github.com/vesoft-inc/nebula-ent/pull/1364. Only create space with 1 part in all tck/pytest cases. (There are even space with 1000 parts before... This will make ent version ci quite unstable, because we need to create RocksDB for each part) Hope ci could handle it now, especially in ent version.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 added do not review PR: not ready for the code review yet ready-for-testing PR: ready for the CI test labels Nov 2, 2022
@critical27 critical27 removed the do not review PR: not ready for the code review yet label Nov 2, 2022
@@ -1,6 +1,6 @@
space:
name: ldbc_v0_3_3
partitionNum: 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this? I think we should test one and more partitions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tck, there is only one storage, what is the point to use multiple partitions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test code logic of partitions.

pengweisong
pengweisong previously approved these changes Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants