-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only create 1 part in tck #4817
Conversation
@@ -1,6 +1,6 @@ | |||
space: | |||
name: ldbc_v0_3_3 | |||
partitionNum: 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this? I think we should test one and more partitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In tck, there is only one storage, what is the point to use multiple partitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test code logic of partitions.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Backport from https://github.com/vesoft-inc/nebula-ent/pull/1364. Only create space with 1 part in all tck/pytest cases. (There are even space with 1000 parts before... This will make ent version ci quite unstable, because we need to create RocksDB for each part) Hope ci could handle it now, especially in ent version.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: