Skip redudant self-reflective edges in GetNeighborsNode

[xtcyclist]

What type of PR is this?

• bug
• feature
• enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4929

Description:

Duplicated results in matches.

Reason:

• Self-reflective edges like (v0)-[e]->(v0) are stored as two different versions in the storage: the outbound one and the inbound one.
• When fetching edges of both directions in the GetNeighborsNode, these two physical versions are treated as two distinct edges, although they are the same edge.
• Such redudant edges returned from the storage cause the query engine's traverse operator to process redudant edges, resulting in extra overhead and wrong results.

How do you solve it?

In the GetNeighborsNode, if an edge fetched from the storage has identical srcID and dstID, check whether it has been visited previously. If so, skip it.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

• Unit test(positive and negative cases)
• Function test
• Performance test
• TCK
• N/A

Affects:

• Documentation affected (Please add the label if documentation needs to be modified.)
• Incompatibility (If it breaks the compatibility, please describe it and add the label.）
• If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
• Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

[critical27]

Good job~ I have some other question, see the issue please.

[codecov-commenter]

Codecov Report

Base: 76.83% // Head: 76.84% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (48b6223) compared to base (7083d72).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4943      +/-   ##
==========================================
+ Coverage   76.83%   76.84%   +0.01%     
==========================================
  Files        1101     1101              
  Lines       81222    81245      +23     
==========================================
+ Hits        62404    62435      +31     
+ Misses      18818    18810       -8     

Impacted Files	Coverage Δ
src/clients/meta/MetaClient.h	92.30% <ø> (ø)
src/graph/executor/query/TraverseExecutor.h	100.00% <ø> (ø)
src/storage/CommonUtils.h	98.27% <ø> (ø)
src/storage/exec/QueryUtils.h	90.90% <ø> (ø)
src/storage/CommonUtils.cpp	91.17% <60.00%> (-5.60%)	⬇️
src/storage/exec/GetNeighborsNode.h	94.54% <100.00%> (+0.79%)	⬆️
src/graph/context/Result.cpp	70.00% <0.00%> (-10.00%)	⬇️
src/graph/planner/Planner.cpp	75.00% <0.00%> (-5.00%)	⬇️
src/graph/executor/query/ProjectExecutor.cpp	62.16% <0.00%> (-2.71%)	⬇️
src/common/expression/UnaryExpression.cpp	83.69% <0.00%> (-2.18%)	⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.