Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync from ent repo for supportting show hosts storage listener #4984

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Dec 4, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Synchronize from the enterprise version, support the following functions:
image

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Base: 76.86% // Head: 76.84% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1fdf6e0) compared to base (8adec8d).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4984      +/-   ##
==========================================
- Coverage   76.86%   76.84%   -0.03%     
==========================================
  Files        1105     1105              
  Lines       81432    81452      +20     
==========================================
- Hits        62594    62589       -5     
- Misses      18838    18863      +25     
Impacted Files Coverage Δ
src/meta/processors/parts/ListHostsProcessor.cpp 69.52% <0.00%> (-2.77%) ⬇️
src/clients/meta/MetaClient.cpp 76.22% <100.00%> (-0.29%) ⬇️
src/meta/processors/admin/HBProcessor.cpp 89.04% <100.00%> (+0.15%) ⬆️
src/meta/processors/job/StorageJobExecutor.cpp 78.99% <100.00%> (ø)
src/meta/processors/listener/ListenerProcessor.cpp 69.90% <100.00%> (ø)
src/storage/StorageServer.cpp 80.27% <100.00%> (ø)
src/kvstore/raftex/Host.cpp 72.34% <0.00%> (-3.86%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/graph/service/PermissionCheck.cpp 79.59% <0.00%> (-2.05%) ⬇️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@critical27
Copy link
Contributor

Involves thrift compactiblity. If no other components use the interface, it is ok.

@codesigner
Copy link
Contributor

Take care when modified the thrift.

Copy link
Contributor

@codesigner codesigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shinji-IkariG Shinji-IkariG force-pushed the support_show_hosts_storage_listener branch from 1fdf6e0 to 425a71a Compare December 5, 2022 07:37
@Sophie-Xie Sophie-Xie merged commit 04ea700 into vesoft-inc:master Dec 5, 2022
@panda-sheep panda-sheep deleted the support_show_hosts_storage_listener branch December 5, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants