Remove the pruning of Expression::Kind::kVarProperty in agg.

[xtcyclist]

What type of PR is this?

• bug
• feature
• enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4974

Description:

match (v0:player)-[e0]->(v1) where id(v0) == "Tim Duncan" unwind e0.start_year as a return count(a)

$a was pruned in this query, causing the unwind operator to produce NULL dataset, which in the end leads to wrong counting results.

How do you solve it?

Disable the pruning of Expression::Kind::kVarProperty and Expression::Kind::kInputProperty in PropertyTrackerVisitor.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

• Unit test(positive and negative cases)
• Function test
• Performance test
• TCK

Affects:

• Documentation affected (Please add the label if documentation needs to be modified.)
• Incompatibility (If it breaks the compatibility, please describe it and add the label.）
• If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
• Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

[codecov-commenter]

Codecov Report

Base: 76.86% // Head: 76.82% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (bcbc623) compared to base (8adec8d).
Patch coverage: 95.74% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4990      +/-   ##
==========================================
- Coverage   76.86%   76.82%   -0.05%     
==========================================
  Files        1105     1105              
  Lines       81432    81473      +41     
==========================================
- Hits        62594    62588       -6     
- Misses      18838    18885      +47     

Impacted Files	Coverage Δ
src/graph/executor/query/TraverseExecutor.h	100.00% <ø> (ø)
src/meta/processors/parts/ListHostsProcessor.cpp	69.52% <0.00%> (-2.77%)	⬇️
src/clients/meta/MetaClient.cpp	76.07% <100.00%> (-0.45%)	⬇️
src/common/function/FunctionManager.cpp	79.40% <100.00%> (+0.12%)	⬆️
src/graph/optimizer/rule/PushEFilterDownRule.cpp	78.35% <100.00%> (-0.44%)	⬇️
src/graph/visitor/PropertyTrackerVisitor.cpp	82.71% <100.00%> (+0.41%)	⬆️
src/meta/processors/admin/HBProcessor.cpp	89.04% <100.00%> (+0.15%)	⬆️
src/meta/processors/job/StorageJobExecutor.cpp	78.99% <100.00%> (ø)
src/meta/processors/listener/ListenerProcessor.cpp	69.90% <100.00%> (ø)
src/storage/StorageServer.cpp	80.27% <100.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.