Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monitoring Metrics to NebulaGraph #5841 #5940

Conversation

E2ern1ty
Copy link
Contributor

@E2ern1ty E2ern1ty commented Sep 6, 2024

What type of PR is this?

  • bug
  • [ ✅] feature
  • enhancement

What problem(s) does this PR solve?

Add-Monitoring-Metrics-to-NebulaGraph

Issue(s) number:

5841

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • [✅] N/A
image

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....
Add-Monitoring-Metrics-to-NebulaGraph

@Salieri-004 Salieri-004 added ready-for-testing PR: ready for the CI test ready for review labels Sep 6, 2024
@E2ern1ty E2ern1ty force-pushed the Add-Monitoring-Metrics-to-NebulaGraph-#5841 branch from 1a665cd to bb8d3da Compare September 6, 2024 06:41
@Salieri-004
Copy link
Contributor

LGTM. Thanks for your help!

@codesigner codesigner enabled auto-merge (squash) September 23, 2024 07:23
@codesigner codesigner merged commit 1cafc2f into vesoft-inc:master Sep 23, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants