Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSSL-11944] add sharedNamespace for cluster env #72

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

thomasgim
Copy link
Contributor

No description provided.

@thomasgim thomasgim requested review from synthdnb and NEM-NE January 17, 2025 09:10
Copy link
Contributor

@synthdnb synthdnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그런데 생각해보니 차트 인스톨할때 네임스페이스 지정할거라 따로 입력 없이 내부에서 참조 가능할 듯 한...?
https://helm.sh/docs/chart_template_guide/builtin_objects/

@thomasgim
Copy link
Contributor Author

그런데 생각해보니 차트 인스톨할때 네임스페이스 지정할거라 따로 입력 없이 내부에서 참조 가능할 듯 한...? https://helm.sh/docs/chart_template_guide/builtin_objects/

오 그러네요...

- name: VESSL_SHARED_NAMESPACE
  value: "{{ .Release.Namespace }}"

이렇게 바꿀까요?

Copy link
Contributor

@synthdnb synthdnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thomasgim thomasgim removed the request for review from NEM-NE January 17, 2025 09:42
@thomasgim thomasgim merged commit 79b3863 into main Jan 17, 2025
@thomasgim thomasgim deleted the vssl-11944 branch January 17, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants